[Solved in 5.4] 2 bugs in list.php

[kintree]

Huub

One serious error, which can lead to fatal SQL errors:

Line 953: $query='';

This code should PRECEDE the condition in Line 952, so that $query is correctly initialised when the condition fails.

One minor error, obviously untested by its coder:

Line 782: else strtoupper($selection['gednr']=$_POST['gednr']);

The code intended was probably: else $selection['gednr']=strtoupper($_POST['gednr']);

[Huub]

Hello kintree,

I have tested both piece of code:

$query is allready declared at line 672:

Code: Select all

$query='';

Line 782 is changed for the next version. I have tested the old code, but it didn't matter if "i" or "I" was used in the search for gedcomnumber.
But the code was wrong, and is improved now!

As you probably can see, the codes of several scripts is changed a lot in many years. We are still trying to improve the scripts (by using functions etc.), and sometimes i'm completely rebuilding a script. But it's a hobby for me, I have to do this in the evening hours and weekends...